[refs #442] Add counters update checking. Add build_error counter

app/models/build_list.rb

@@ -105,9 +105,9 @@ class BuildList < ActiveRecord::Base
 
     around_transition do |build_list, transition, block|
       if build_list.mass_build
-        MassBuild.decrement_counter "#{BuildList::HUMAN_STATUSES[build_list.status].to_s}_count", build_list.mass_build_id
+        MassBuild.decrement_counter "#{BuildList::HUMAN_STATUSES[build_list.status].to_s}_count", build_list.mass_build_id if MassBuild::COUNT_STATUSES.include?(build_list.status)
         block.call
-        MassBuild.increment_counter "#{BuildList::HUMAN_STATUSES[build_list.status].to_s}_count", build_list.mass_build_id
+        MassBuild.increment_counter "#{BuildList::HUMAN_STATUSES[build_list.status].to_s}_count", build_list.mass_build_id if MassBuild::COUNT_STATUSES.include?(build_list.status)
       end
     end
 

app/models/mass_build.rb

@@ -12,6 +12,15 @@ class MassBuild < ActiveRecord::Base
 
   after_create :build_all
 
+  COUNT_STATUSES = [
+    :build_lists,
+    :build_published,
+    :build_pending,
+    :build_started,
+    :build_publish,
+    :build_error
+  ]
+
   def initialize(args = nil)
     super
 

app/views/platforms/platforms/build_all.html.haml

@@ -35,6 +35,7 @@
       %th.lpadding16= t("layout.build_lists.statuses.build_pending").camelize
       %th.lpadding16= t("layout.build_lists.statuses.build_started").camelize
       %th.lpadding16= t("layout.build_lists.statuses.build_publish").camelize
+      %th.lpadding16= t("layout.build_lists.statuses.build_error").camelize
       %th.lpadding16= t("layout.mass_builds.extended_data")
   - @mass_builds.each do |mass_build|
     %tr
@@ -45,6 +46,7 @@
       %td= mass_build.build_pending_count
       %td= mass_build.build_started_count
       %td= mass_build.build_publish_count
+      %td= mass_build.build_error_count
       %td
         %a{:href => '#', :'data-toggle' => "collapse", :'data-target' => "#collapse_#{ mass_build.id }"}= t("layout.mass_builds.extended_data")
         .in.collapse{:id => "collapse_#{ mass_build.id }"}

config/locales/models/mass_build.ru.yml

@@ -2,7 +2,7 @@ ru:
   layout:
     mass_builds:
       repositories: Репозитории
-      extended_data: Дополнительные данные
+      extended_data: Параметры задания
   activerecord:
     models:
       mass_build: Массовая Сборка

db/migrate/20120622092725_add_counters_to_mass_builds.rb

@@ -5,5 +5,6 @@ class AddCountersToMassBuilds < ActiveRecord::Migration
     add_column :mass_builds, :build_pending_count, :integer, :default => 0
     add_column :mass_builds, :build_started_count, :integer, :default => 0
     add_column :mass_builds, :build_publish_count, :integer, :default => 0
+    add_column :mass_builds, :build_error_count, :integer, :default => 0
   end
 end