Software
/
rosa-build
mirror of https://github.com/OpenMandrivaSoftware/rosa-build.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

#465 update comment specs

This commit is contained in:
Alexander Machehin 2015-04-13 15:15:55 +05:00
parent 09afec1ad6
commit dd58b4a0a5
2 changed files with 135 additions and 235 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

329
spec/models/comment_spec.rb
View File

@ -1,196 +1,133 @@
# require 'spec_helper'
# require "cancan/matchers"
#
# def set_commentable_data
# @ability = Ability.new(@user)
#
# @project = FactoryGirl.create(:project)
# @issue = FactoryGirl.create(:issue, project_id: @project.id, user: @user)
#
# @comment = FactoryGirl.create(:comment, commentable: @issue, user: @user, project: @project)
# @stranger_comment = FactoryGirl.create(:comment, commentable: @issue, user: @stranger, project: @project)
#
# allow_any_instance_of(Project).to receive(:versions).and_return(%w(v1.0 v2.0))
# end
#
# def create_comment_in_issue issue, body
# FactoryGirl.create(:comment, user: issue.user, commentable: issue, project: issue.project, body: body)
# end
#
# describe Comment do
# before { stub_symlink_methods }
# context 'for global admin user' do
# before(:each) do
# @user = FactoryGirl.create(:admin)
# @stranger = FactoryGirl.create(:user)
#
# set_commentable_data
# end
#
# it_should_behave_like 'user with create comment ability (for model)'
# it_should_behave_like 'user with update own comment ability (for model)'
# it_should_behave_like 'user with update stranger comment ability (for model)'
# it_should_behave_like 'user with destroy comment ability (for model)'
# it_should_behave_like 'user with destroy stranger comment ability (for model)'
# end
#
# context 'for project admin user' do
# before(:each) do
# @user = FactoryGirl.create(:user)
# @stranger = FactoryGirl.create(:user)
#
# set_commentable_data
# create_relation(@project, @user, 'admin')
# end
#
# it_should_behave_like 'user with create comment ability (for model)'
# it_should_behave_like 'user with update own comment ability (for model)'
# it_should_behave_like 'user with update stranger comment ability (for model)'
# it_should_behave_like 'user with destroy comment ability (for model)'
# it_should_behave_like 'user with destroy stranger comment ability (for model)'
#
# pending "sends an e-mail" do
# ActionMailer::Base.deliveries.last.to.include?(@stranger.email).should == true
# end
# end
#
# context 'for project owner user' do
# before(:each) do
# @user = FactoryGirl.create(:user)
# @stranger = FactoryGirl.create(:user)
#
# set_commentable_data
#
# @project.owner = @user
# @project.save
# create_relation(@project, @user, 'admin')
# end
#
# it_should_behave_like 'user with create comment ability (for model)'
# it_should_behave_like 'user with update own comment ability (for model)'
# it_should_behave_like 'user with update stranger comment ability (for model)'
# it_should_behave_like 'user with destroy comment ability (for model)'
# it_should_behave_like 'user with destroy stranger comment ability (for model)'
# end
#
# context 'for simple user' do
# before(:each) do
# @user = FactoryGirl.create(:user)
# @stranger = FactoryGirl.create(:user)
#
# set_commentable_data
# end
#
# it_should_behave_like 'user with create comment ability (for model)'
# it_should_behave_like 'user with update own comment ability (for model)'
# it_should_behave_like 'user without update stranger comment ability (for model)'
# it_should_behave_like 'user with destroy comment ability (for model)'
# it_should_behave_like 'user without destroy stranger comment ability (for model)'
#
# context 'with mass assignment' do
# it 'should not be able to update commentable' do
# @comment.update_attributes({commentable_type: 'Grit::Commit', commentable_id: 0})
# @comment.reload.commentable_id.should eql @issue.id
# @comment.reload.commentable_type.should eql @issue.class.name
# end
#
# it 'should not be able to update owner' do
# @comment.should_not allow_mass_assignment_of :user_id
# end
#
# it 'should not be able to update project' do
# @comment.should_not allow_mass_assignment_of :project_id
# end
# end
#
# context 'automatic issue linking' do
# before(:each) do
# @same_name_project = FactoryGirl.create(:project, name: @project.name)
# @issue_in_same_name_project = FactoryGirl.create(:issue, project: @same_name_project, user: @same_name_project.owner)
# @another_project = FactoryGirl.create(:project, owner: @user)
# @other_user_project = FactoryGirl.create(:project)
# @issue = FactoryGirl.create(:issue, project: @project, user: @user)
# @second_issue = FactoryGirl.create(:issue, project: @project, user: @user)
# @issue_in_another_project = FactoryGirl.create(:issue, project: @another_project, user: @user)
# @issue_in_other_user_project = FactoryGirl.create(:issue, project: @other_user_project, user: @other_user_project.owner)
# end
#
# it 'should create automatic comment' do
# create_comment_in_issue(@issue, "test link to ##{@issue.serial_id}; [##{@second_issue.serial_id}]")
# Comment.where(automatic: true, commentable_type: 'Issue',
# commentable_id: @second_issue.id,
# created_from_issue_id: @issue.id).count.should == 1
# end
#
# it 'should not create automatic comment to the same issue' do
# create_comment_in_issue(@issue, "test link to ##{@issue.serial_id}; [##{@second_issue.serial_id}]")
# Comment.where(automatic: true,
# created_from_issue_id: @issue.id).count.should == 1
# end
#
# it 'should create automatic comment in the another project issue' do
# body = "[#{@another_project.name_with_owner}##{@issue_in_another_project.serial_id}]"
# create_comment_in_issue(@issue, body)
# Comment.where(automatic: true, commentable_type: 'Issue',
# commentable_id: @issue_in_another_project.id,
# created_from_issue_id: @issue.id).count.should == 1
# end
#
# it 'should create automatic comment in the same name project issue' do
# body = "[#{@same_name_project.owner.uname}##{@issue_in_same_name_project.serial_id}]"
# create_comment_in_issue(@issue, body)
# Comment.where(automatic: true, commentable_type: 'Issue',
# commentable_id: @issue_in_same_name_project.id,
# created_from_issue_id: @issue.id).count.should == 1
# end
#
# it 'should not create duplicate automatic comment' do
# create_comment_in_issue(@issue, "test link to [##{@second_issue.serial_id}]")
# create_comment_in_issue(@issue, "test duplicate link to [##{@second_issue.serial_id}]")
# Comment.where(automatic: true, commentable_type: 'Issue',
# commentable_id: @second_issue.id,
# created_from_issue_id: @issue.id).count.should == 1
# end
#
# it 'should not create duplicate automatic comment from one' do
# create_comment_in_issue(@issue, "test link to [##{@second_issue.serial_id}]; ##{@second_issue.serial_id}")
# Comment.where(automatic: true, commentable_type: 'Issue',
# commentable_id: @second_issue.id,
# created_from_issue_id: @issue.id).count.should == 1
# end
#
# it 'should create two automatic comment' do
# body = "test ##{@second_issue.serial_id}" +
# " && [#{@another_project.name_with_owner}##{@issue_in_another_project.serial_id}]"
# create_comment_in_issue(@issue, body)
# Comment.where(automatic: true,
# created_from_issue_id: @issue.id).count.should == 2
# end
#
# it 'should create automatic comment by issue title' do
# issue = FactoryGirl.create(:issue, project: @project, user: @user,
# title: "link to ##{@issue.serial_id}")
# expect(Comment.where(automatic: true,
# created_from_issue_id: issue.id).count).to eq 1
# end
#
# it 'should create automatic comment from issue body' do
# issue = FactoryGirl.create(:issue, project: @project, user: @user,
# body: "link to ##{@issue.serial_id}")
# Comment.where(automatic: true,
# created_from_issue_id: issue.id).count.should == 1
# end
#
# it 'should create only one automatic comment from issue title and body' do
# issue = FactoryGirl.create(:issue, project: @project, user: @user,
# title: "link to ##{@issue.serial_id} in title",
# :body => "link to ##{@issue.serial_id} in body")
# Comment.where(automatic: true,
# created_from_issue_id: issue.id).count.should == 1
# end
#
#
#
# end
# end
# end
require 'spec_helper'
def set_commentable_data
@project = FactoryGirl.create(:project)
@issue = FactoryGirl.create(:issue, project_id: @project.id, user: @user)
@comment = FactoryGirl.create(:comment, commentable: @issue, user: @user, project: @project)
@stranger_comment = FactoryGirl.create(:comment, commentable: @issue, user: @stranger, project: @project)
allow_any_instance_of(Project).to receive(:versions).and_return(%w(v1.0 v2.0))
end
def create_comment_in_issue issue, body
FactoryGirl.create(:comment, user: issue.user, commentable: issue, project: issue.project, body: body)
end
describe Comment do
before { stub_symlink_methods }
context 'for simple user' do
before(:each) do
@user = FactoryGirl.create(:user)
@stranger = FactoryGirl.create(:user)
set_commentable_data
end
context 'with mass assignment' do
it 'should not be able to update commentable' do
@comment.update_attributes({commentable_type: 'Grit::Commit', commentable_id: 0})
expect(@comment.reload.commentable).to eq(@issue)
end
end
context 'automatic issue linking' do
before(:each) do
@same_name_project = FactoryGirl.create(:project, name: @project.name)
@issue_in_same_name_project = FactoryGirl.create(:issue, project: @same_name_project, user: @same_name_project.owner)
@another_project = FactoryGirl.create(:project, owner: @user)
@other_user_project = FactoryGirl.create(:project)
@issue = FactoryGirl.create(:issue, project: @project, user: @user)
@second_issue = FactoryGirl.create(:issue, project: @project, user: @user)
@issue_in_another_project = FactoryGirl.create(:issue, project: @another_project, user: @user)
@issue_in_other_user_project = FactoryGirl.create(:issue, project: @other_user_project, user: @other_user_project.owner)
end
it 'should create automatic comment' do
create_comment_in_issue(@issue, "test link to ##{@issue.serial_id}; [##{@second_issue.serial_id}]")
expect(
Comment.where(automatic: true, commentable_type: 'Issue',
commentable_id: @second_issue.id,
created_from_issue_id: @issue.id).count
).to eq(1)
end
it 'should not create automatic comment to the same issue' do
create_comment_in_issue(@issue, "test link to ##{@issue.serial_id}; [##{@second_issue.serial_id}]")
expect(
Comment.where(automatic: true,
created_from_issue_id: @issue.id).count
).to eq(1)
end
it 'should create automatic comment in the another project issue' do
body = "[#{@another_project.name_with_owner}##{@issue_in_another_project.serial_id}]"
create_comment_in_issue(@issue, body)
expect(
Comment.where(automatic: true, commentable_type: 'Issue',
commentable_id: @issue_in_another_project.id,
created_from_issue_id: @issue.id).count
).to eq(1)
end
it 'should create automatic comment in the same name project issue' do
body = "[#{@same_name_project.owner.uname}##{@issue_in_same_name_project.serial_id}]"
create_comment_in_issue(@issue, body)
expect(
Comment.where(automatic: true, commentable_type: 'Issue',
commentable_id: @issue_in_same_name_project.id,
created_from_issue_id: @issue.id).count
).to eq(1)
end
it 'should not create duplicate automatic comment' do
create_comment_in_issue(@issue, "test link to [##{@second_issue.serial_id}]")
create_comment_in_issue(@issue, "test duplicate link to [##{@second_issue.serial_id}]")
expect(
Comment.where(automatic: true, commentable_type: 'Issue',
commentable_id: @second_issue.id,
created_from_issue_id: @issue.id).count
).to eq(1)
end
it 'should not create duplicate automatic comment from one' do
create_comment_in_issue(@issue, "test link to [##{@second_issue.serial_id}]; ##{@second_issue.serial_id}")
expect(
Comment.where(automatic: true, commentable_type: 'Issue',
commentable_id: @second_issue.id,
created_from_issue_id: @issue.id).count
).to eq(1)
end
it 'should create two automatic comment' do
body = "test ##{@second_issue.serial_id}" +
" && [#{@another_project.name_with_owner}##{@issue_in_another_project.serial_id}]"
create_comment_in_issue(@issue, body)
expect(Comment.where(automatic: true,
created_from_issue_id: @issue.id).count).to eq(2)
end
it 'should create automatic comment by issue title' do
issue = FactoryGirl.create(:issue, project: @project, user: @user,
title: "link to ##{@issue.serial_id}")
expect(Comment.where(automatic: true,
created_from_issue_id: issue.id).count).to eq(1)
end
it 'should create automatic comment from issue body' do
issue = FactoryGirl.create(:issue, project: @project, user: @user,
body: "link to ##{@issue.serial_id}")
expect(Comment.where(automatic: true,
created_from_issue_id: issue.id).count).to eq(1)
end
it 'should create only one automatic comment from issue title and body' do
issue = FactoryGirl.create(:issue, project: @project, user: @user,
title: "link to ##{@issue.serial_id} in title",
:body => "link to ##{@issue.serial_id} in body")
expect(Comment.where(automatic: true,
created_from_issue_id: issue.id).count).to eq(1)
end
end
end
end

41
spec/support/shared_examples/comments.rb
View File

@ -1,40 +1,3 @@
shared_examples_for 'user with create comment ability (for model)' do
it 'should create comment' do
@ability.should be_able_to(:create, @comment)
end
end
shared_examples_for 'user with update own comment ability (for model)' do
it 'should update comment' do
@ability.should be_able_to(:update, @comment)
end
end
shared_examples_for 'user with update stranger comment ability (for model)' do
it 'should update stranger comment' do
@ability.should be_able_to(:update, @stranger_comment)
end
end
shared_examples_for 'user with destroy comment ability (for model)' do
it 'should destroy own comment' do
@ability.should be_able_to(:destroy, @comment)
end
end
shared_examples_for 'user with destroy stranger comment ability (for model)' do
it 'should destroy stranger comment' do
@ability.should be_able_to(:destroy, @stranger_comment)
end
end
shared_examples_for 'user without update stranger comment ability (for model)' do
it 'should not update stranger comment' do
@ability.should_not be_able_to(:update, @stranger_comment)
end
end
shared_examples_for 'user without destroy stranger comment ability (for model)' do
it 'should not destroy stranger comment' do
@ability.should_not be_able_to(:destroy, @stranger_comment)
end
end
shared_examples_for 'user with create comment ability' do
it 'should be able to perform create action' do
post :create, @create_params
@ -42,9 +5,9 @@ shared_examples_for 'user with create comment ability' do
end
it 'should create comment in the database' do
expect do
expect {
post :create, @create_params
end.to change(Comment, :count).by(1)
}.to change(Comment, :count).by(1)
end
end
shared_examples_for 'user with update own comment ability' do