#756: fixed "NoMethodError: protected method `perform' "

lib/abf_worker/base_observer.rb

@@ -8,22 +8,22 @@ module AbfWorker
 
     attr_accessor :status, :options
 
-    protected
-
     def initialize(options, subject_class)
       @status   = options['status'].to_i
       @options  = options
       @subject_class = subject_class
     end
 
-    def subject
-      @subject ||= @subject_class.find options['id']
-    end
-
     def perform
       raise NotImplementedError, "You should implement this method"
     end
 
+    protected
+
+    def subject
+      @subject ||= @subject_class.find options['id']
+    end
+
     def update_results
       results = (subject.results || []) + options['results']
       sort_results_and_save results

lib/abf_worker/iso_worker_observer.rb

@@ -6,8 +6,6 @@ module AbfWorker
       new(options, ProductBuildList).perform
     end
 
-    protected
-
     def perform
       case status
       when COMPLETED

lib/abf_worker/publish_observer.rb

@@ -7,8 +7,6 @@ module AbfWorker
       new(options, BuildList).perform
     end
 
-    protected
-
     def perform
       return if status == STARTED # do nothing when publication started
       if options['type'] == 'resign'
@@ -28,6 +26,8 @@ module AbfWorker
       end
     end
 
+    protected
+
     def update_rpm_builds
       build_lists = BuildList.where(:id => options['build_list_ids'])
       build_lists.each do |build_list| 

lib/abf_worker/rpm_worker_observer.rb

@@ -8,8 +8,6 @@ module AbfWorker
       new(options, BuildList).perform
     end
 
-    protected
-
     def perform
       item = find_or_create_item
 
@@ -34,6 +32,8 @@ module AbfWorker
       item.update_attributes({:status => BuildList::SUCCESS}) if [TESTS_FAILED, COMPLETED].include?(status)
     end
 
+    protected
+
     def find_or_create_item
       subject.items.first || subject.items.create({
         :version => subject.commit_hash,