Merge pull request #423 from abf/rosa-build:fix_api_missing_template

fix ActionView::MissingTemplate

app/controllers/api/v1/advisories_controller.rb

@@ -6,12 +6,13 @@ class Api::V1::AdvisoriesController < Api::V1::BaseController
   authorize_resource :build_list, only: [:create, :update]
 
   def index
-    @advisories = @advisories.includes(:platforms, :projects).
+    @advisories = @advisories.includes(:platforms, :projects).paginate(paginate_params)
-      paginate(paginate_params)
+    respond_to :json
   end
 
   def show
     @packages_info = @advisory.fetch_packages_info
+    respond_to :json
   end
 
   def create

app/controllers/api/v1/arches_controller.rb

@@ -3,6 +3,7 @@ class Api::V1::ArchesController < Api::V1::BaseController
 
   def index
     @arches = Arch.order(:id).paginate(paginate_params)
+    respond_to :json
   end
 
 end

app/controllers/api/v1/base_controller.rb

@@ -1,6 +1,6 @@
 class Api::V1::BaseController < ApplicationController
   include PaginateHelper
-  #respond_to :json
+  respond_to :json
 
   helper_method :member_path
 

app/controllers/api/v1/build_lists_controller.rb

@@ -1,16 +1,20 @@
 class Api::V1::BuildListsController < Api::V1::BaseController
-
   before_filter :authenticate_user!
   skip_before_filter :authenticate_user!, only: [:show, :index] if APP_CONFIG['anonymous_access']
 
   load_resource :project, only: :index, parent: false
   load_and_authorize_resource :build_list, only: [:show, :create, :cancel, :publish, :reject_publish, :create_container, :publish_into_testing, :rerun_tests]
 
+  def show
+    respond_to :json
+  end
+
   def index
     authorize!(:show, @project) if @project
     filter = BuildList::Filter.new(@project, current_user, current_ability, params[:filter] || {})
     @build_lists = filter.find.includes(:save_to_platform, :project, :user, :arch)
     @build_lists = @build_lists.recent.paginate(paginate_params)
+    respond_to :json
   end
 
   def create

app/controllers/api/v1/groups_controller.rb

@@ -7,15 +7,17 @@ class Api::V1::GroupsController < Api::V1::BaseController
   def index
     # accessible_by(current_ability)
     @groups = current_user.groups.paginate(paginate_params)
+    respond_to :json
   end
 
   def show
+    respond_to :json
   end
 
   def members
-    @members = @group.members.
+    @members = @group.members.where('actor_id != ?', @group.owner_id)
-      where('actor_id != ?', @group.owner_id).
+                     .order('name').paginate(paginate_params)
-      order('name').paginate(paginate_params)
+    respond_to :json
   end
 
   def update

app/controllers/api/v1/issues_controller.rb

@@ -1,6 +1,4 @@
 class Api::V1::IssuesController < Api::V1::BaseController
-  respond_to :json
-
   before_filter :authenticate_user!
   skip_before_filter :authenticate_user!, only: [:index, :group_index, :show] if APP_CONFIG['anonymous_access']
 
@@ -34,7 +32,11 @@ class Api::V1::IssuesController < Api::V1::BaseController
   end
 
   def show
-    redirect_to api_v1_project_pull_request_path(@project.id, @issue.serial_id) if @issue.pull_request
+    if @issue.pull_request
+      redirect_to api_v1_project_pull_request_path(@project.id, @issue.serial_id)
+    else
+      respond_to :json
+    end
   end
 
   def create
@@ -102,7 +104,10 @@ class Api::V1::IssuesController < Api::V1::BaseController
 
     @issues = @issues.where('issues.created_at >= to_timestamp(?)', params[:since]) if params[:since] =~ /\A\d+\z/
     @issues = @issues.paginate(paginate_params)
-    render :index
+
+    respond_to do |format|
+      format.json { render :index }
+    end
   end
 
   def get_all_project_ids default_project_ids

app/controllers/api/v1/maintainers_controller.rb

@@ -7,5 +7,6 @@ class Api::V1::MaintainersController < Api::V1::BaseController
                                      .actual.by_platform(@platform)
                                      .like_name(params[:package_name])
                                      .paginate(paginate_params)
+    respond_to :json
   end
 end

app/controllers/api/v1/platforms_controller.rb

@@ -16,16 +16,20 @@ class Api::V1::PlatformsController < Api::V1::BaseController
   end
 
   def index
-    @platforms = @platforms.accessible_by(current_ability, :related).
+    @platforms = @platforms.accessible_by(current_ability, :related)
-      by_type(params[:type]).paginate(paginate_params)
+                           .by_type(params[:type]).paginate(paginate_params)
+    respond_to :json
   end
 
   def show
+    respond_to :json
   end
 
   def platforms_for_build
   	@platforms = Platform.main.opened.paginate(paginate_params)
-  	render :index
+    respond_to do |format|
+      format.json { render :index }
+    end
   end
 
   def create
@@ -44,6 +48,7 @@ class Api::V1::PlatformsController < Api::V1::BaseController
 
   def members
     @members = @platform.members.order('name').paginate(paginate_params)
+    respond_to :json
   end
 
   def add_member

app/controllers/api/v1/product_build_lists_controller.rb

@@ -13,6 +13,7 @@ class Api::V1::ProductBuildListsController < Api::V1::BaseController
                            end
     @product_build_lists = @product_build_lists.joins(:product, :project, :arch)
     @product_build_lists = @product_build_lists.recent.paginate(paginate_params)
+    respond_to :json
   end
 
   def create
@@ -24,6 +25,7 @@ class Api::V1::ProductBuildListsController < Api::V1::BaseController
   end
 
   def show
+    respond_to :json
   end
 
   def update

app/controllers/api/v1/products_controller.rb

@@ -13,6 +13,7 @@ class Api::V1::ProductsController < Api::V1::BaseController
   end
 
   def show
+    respond_to :json
   end
 
   def destroy

app/controllers/api/v1/projects_controller.rb

@@ -6,8 +6,9 @@ class Api::V1::ProjectsController < Api::V1::BaseController
   load_and_authorize_resource :project
 
   def index
-    @projects = Project.accessible_by(current_ability, :membered).
+    @projects = Project.accessible_by(current_ability, :membered)
-      paginate(paginate_params)
+                       .paginate(paginate_params)
+    respond_to :json
   end
 
   def get_id
@@ -16,13 +17,16 @@ class Api::V1::ProjectsController < Api::V1::BaseController
     else
       raise ActiveRecord::RecordNotFound
     end
+    respond_to :json
   end
 
   def show
+    respond_to :json
   end
 
   def refs_list
     @refs = @project.repo.branches + @project.repo.tags.select{ |t| t.commit }
+    respond_to :json
   end
 
   def update
@@ -48,6 +52,7 @@ class Api::V1::ProjectsController < Api::V1::BaseController
 
   def members
     @members = @project.collaborators.order('uname').paginate(paginate_params)
+    respond_to :json
   end
 
   def add_member

app/controllers/api/v1/pull_requests_controller.rb

@@ -39,6 +39,7 @@ class Api::V1::PullRequestsController < Api::V1::BaseController
 
   def show
     redirect_to api_v1_project_issue_path(@project.id, @issue.serial_id) if @pull.nil?
+    respond_to :json
   end
 
   def create
@@ -95,10 +96,12 @@ class Api::V1::PullRequestsController < Api::V1::BaseController
 
   def commits
     @commits = @pull.repo.commits_between(@pull.to_commit, @pull.from_commit).paginate(paginate_params)
+    respond_to :json
   end
 
   def files
     @stats = @pull.diff_stats.zip(@pull.diff).paginate(paginate_params)
+    respond_to :json
   end
 
   def merge
@@ -149,7 +152,10 @@ class Api::V1::PullRequestsController < Api::V1::BaseController
 
     @pulls = @pulls.where('issues.created_at >= to_timestamp(?)', params[:since]) if params[:since] =~ /\A\d+\z/
     @pulls = @pulls.paginate(paginate_params)
-    render :index
+
+    respond_to do |format|
+      format.json { render :index }
+    end
   end
 
   def get_all_project_ids default_project_ids

app/controllers/api/v1/repositories_controller.rb

@@ -1,4 +1,5 @@
 class Api::V1::RepositoriesController < Api::V1::BaseController
+  respond_to :csv, only: :packages
 
   before_filter :authenticate_user!
   skip_before_filter :authenticate_user!, only: [:show, :projects] if APP_CONFIG['anonymous_access']
@@ -6,11 +7,12 @@ class Api::V1::RepositoriesController < Api::V1::BaseController
   load_and_authorize_resource :repository, through: :platform, shallow: true
 
   def show
+    respond_to :json
   end
 
   def projects
-    @projects = @repository.projects.
+    @projects = @repository.projects.recent.paginate(paginate_params)
-      recent.paginate(paginate_params)
+    respond_to :json
   end
 
   def update
@@ -30,6 +32,7 @@ class Api::V1::RepositoriesController < Api::V1::BaseController
   end
 
   def key_pair
+    respond_to :json
   end
 
   # Only one request per 15 minutes for each platform

app/controllers/api/v1/search_controller.rb

@@ -7,5 +7,6 @@ class Api::V1::SearchController < Api::V1::BaseController
       (params[:type] || 'all'),
       paginate_params
     )
+    respond_to :json
   end
 end

app/controllers/api/v1/users_controller.rb

@@ -7,10 +7,13 @@ class Api::V1::UsersController < Api::V1::BaseController
 
   def show
     @user = User.opened.find params[:id] # dont show system users
+    respond_to :json
   end
 
   def show_current_user
-    render :show
+    respond_to do |format|
+      format.json { render :show }
+    end
   end
 
   def update
@@ -35,7 +38,7 @@ class Api::V1::UsersController < Api::V1::BaseController
         render_json_response @user, error_message(@user.notifier, 'User notification settings have not been updated'), 422
       end
     else
-      render :notifiers
+      respond_to :json
     end
   end