From 06a4e6da7fd4793d638a90963b3b618829c73247 Mon Sep 17 00:00:00 2001
From: Vokhmin Alexey V <avokhmin@gmail.com>
Date: Sat, 11 Apr 2015 01:04:23 +0300
Subject: [PATCH] #465: Added specs for CommentPolicy

---
 app/policies/comment_policy.rb       |  2 +-
 spec/policies/comment_policy_spec.rb | 47 ++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+), 1 deletion(-)
 create mode 100644 spec/policies/comment_policy_spec.rb

diff --git a/app/policies/comment_policy.rb b/app/policies/comment_policy.rb
index 10ade4626..38cd43661 100644
--- a/app/policies/comment_policy.rb
+++ b/app/policies/comment_policy.rb
@@ -1,7 +1,7 @@
 class CommentPolicy < ApplicationPolicy
 
   def create?
-    ProjectPolicy.new(user, record.project).show?
+    !user.guest? && ProjectPolicy.new(user, record.project).show?
   end
   alias_method :new_line?, :create?
 
diff --git a/spec/policies/comment_policy_spec.rb b/spec/policies/comment_policy_spec.rb
new file mode 100644
index 000000000..4787b6866
--- /dev/null
+++ b/spec/policies/comment_policy_spec.rb
@@ -0,0 +1,47 @@
+require 'spec_helper'
+
+RSpec.describe CommentPolicy, type: :policy do
+  let(:comment) { FactoryGirl.build(:comment) }
+  subject { described_class }
+
+  %i(create? new_line?).each do |perm|
+    permissions perm do
+      it "denies access to anonymous user" do
+        expect(subject).to_not permit(User.new, comment)
+      end
+
+      it "denies access if user can not read a project" do
+        allow_any_instance_of(ProjectPolicy).to receive(:show?).and_return(false)
+        expect(subject).to_not permit(FactoryGirl.create(:user), comment)
+      end
+
+      it "grants access if user can read a project" do
+        allow_any_instance_of(ProjectPolicy).to receive(:show?).and_return(true)
+        expect(subject).to permit(FactoryGirl.create(:user), comment)
+      end
+    end
+  end
+
+  %i(update? destroy?).each do |perm|
+    permissions perm do
+      it "denies access to user" do
+        expect(subject).to_not permit(User.new, comment)
+      end
+
+      it "grants access for creator" do
+        expect(subject).to permit(comment.user, comment)
+      end
+
+      it "grants access for admin of project" do
+        allow_any_instance_of(CommentPolicy).to receive(:local_admin?).
+          with(comment.project).and_return(true)
+        expect(subject).to permit(User.new, comment)
+      end
+
+      it "grants access for to global admin" do
+        expect(subject).to permit(FactoryGirl.build(:admin), comment)
+      end
+    end
+  end
+
+end