2012-01-30 20:39:34 +00:00
|
|
|
# -*- encoding : utf-8 -*-
|
2011-12-19 15:30:14 +00:00
|
|
|
require 'spec_helper'
|
|
|
|
|
2012-08-15 14:52:32 +01:00
|
|
|
shared_context "issues controller" do
|
2013-04-03 12:11:50 +01:00
|
|
|
before do
|
2012-08-15 14:52:32 +01:00
|
|
|
stub_symlink_methods
|
|
|
|
|
2013-07-22 16:19:25 +01:00
|
|
|
@project = FactoryGirl.create(:project_with_commit)
|
2012-08-15 14:52:32 +01:00
|
|
|
@issue_user = FactoryGirl.create(:user)
|
|
|
|
|
|
|
|
@issue = FactoryGirl.create(:issue, :project_id => @project.id, :assignee_id => @issue_user.id)
|
2013-04-03 12:11:50 +01:00
|
|
|
@label = FactoryGirl.create(:label, :project_id => @project.id)
|
2012-08-15 14:52:32 +01:00
|
|
|
|
|
|
|
@project_with_turned_off_issues = FactoryGirl.create(:project, :has_issues => false)
|
|
|
|
@turned_of_issue = FactoryGirl.create(:issue, :project_id => @project_with_turned_off_issues.id, :assignee_id => @issue_user.id)
|
2012-09-06 18:45:13 +01:00
|
|
|
|
|
|
|
@user = FactoryGirl.create(:user)
|
|
|
|
set_session_for(@user)
|
2012-08-15 14:52:32 +01:00
|
|
|
|
|
|
|
@create_params = {
|
|
|
|
:owner_name => @project.owner.uname, :project_name => @project.name,
|
|
|
|
:issue => {
|
|
|
|
:title => "issue1",
|
2013-04-03 12:11:50 +01:00
|
|
|
:body => "issue body",
|
|
|
|
:labelings_attributes => { @label.id => {:label_id => @label.id}},
|
|
|
|
:assignee_id => @issue_user.id
|
|
|
|
}
|
2012-08-15 14:52:32 +01:00
|
|
|
}
|
2012-09-06 18:45:13 +01:00
|
|
|
|
2012-08-15 14:52:32 +01:00
|
|
|
@update_params = {
|
|
|
|
:owner_name => @project.owner.uname, :project_name => @project.name,
|
|
|
|
:issue => {
|
|
|
|
:title => "issue2"
|
|
|
|
}
|
|
|
|
}
|
2012-09-06 18:45:13 +01:00
|
|
|
|
2013-07-22 16:19:25 +01:00
|
|
|
@pull = @project.pull_requests.new :issue_attributes => {:title => 'test', :body => 'testing'}
|
|
|
|
@pull.issue.user, @pull.issue.project = @project.owner, @pull.to_project
|
|
|
|
@pull.to_ref = 'master'
|
|
|
|
@pull.from_project, @pull.from_ref = @project, 'non_conflicts'
|
|
|
|
@pull.save
|
2012-08-15 14:52:32 +01:00
|
|
|
end
|
2012-09-06 18:45:13 +01:00
|
|
|
|
2012-08-15 14:52:32 +01:00
|
|
|
end
|
|
|
|
|
2012-09-06 18:45:13 +01:00
|
|
|
shared_examples_for 'issue user with project guest rights' do
|
2011-12-23 10:56:46 +00:00
|
|
|
it 'should be able to perform index action' do
|
2012-04-23 21:55:42 +01:00
|
|
|
get :index, :owner_name => @project.owner.uname, :project_name => @project.name
|
2011-12-23 10:56:46 +00:00
|
|
|
response.should render_template(:index)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'should be able to perform show action' do
|
2012-04-23 21:55:42 +01:00
|
|
|
get :show, :owner_name => @project.owner.uname, :project_name => @project.name, :id => @issue.serial_id
|
2011-12-23 10:56:46 +00:00
|
|
|
response.should render_template(:show)
|
|
|
|
end
|
2012-09-06 18:45:13 +01:00
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples_for 'issue user with project reader rights' do
|
2012-05-30 17:03:07 +01:00
|
|
|
|
|
|
|
it 'should be able to perform index action on hidden project' do
|
2012-09-06 11:53:03 +01:00
|
|
|
@project.update_attributes(:visibility => 'hidden')
|
2012-05-30 17:03:07 +01:00
|
|
|
get :index, :owner_name => @project.owner.uname, :project_name => @project.name
|
|
|
|
response.should render_template(:index)
|
|
|
|
end
|
2011-12-23 10:56:46 +00:00
|
|
|
|
|
|
|
it 'should be able to perform create action' do
|
|
|
|
post :create, @create_params
|
|
|
|
response.should redirect_to(project_issues_path(@project))
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'should create issue object into db' do
|
|
|
|
lambda{ post :create, @create_params }.should change{ Issue.count }.by(1)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2013-04-03 12:11:50 +01:00
|
|
|
shared_examples_for 'issue user with project writer rights' do
|
|
|
|
it 'should be able to perform index action on hidden project' do
|
|
|
|
@project.update_attributes(:visibility => 'hidden')
|
|
|
|
get :index, :owner_name => @project.owner.uname, :project_name => @project.name
|
|
|
|
response.should render_template(:index)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'should create issue object into db' do
|
|
|
|
lambda{ post :create, @create_params }.should change{ Issue.count }.by(1)
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'perform create action' do
|
|
|
|
before { post :create, @create_params }
|
|
|
|
|
|
|
|
it 'user should be assigned to issue' do
|
|
|
|
@project.issues.last.assignee_id.should_not be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'label should be attached to issue' do
|
|
|
|
@project.issues.last.labels.should have(1).item
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2011-12-23 10:56:46 +00:00
|
|
|
shared_examples_for 'user with issue update rights' do
|
|
|
|
it 'should be able to perform update action' do
|
2011-12-28 02:57:42 +00:00
|
|
|
put :update, {:id => @issue.serial_id}.merge(@update_params)
|
2012-03-02 16:52:15 +00:00
|
|
|
response.code.should eq('200')
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'should update issue title' do
|
2011-12-28 02:57:42 +00:00
|
|
|
put :update, {:id => @issue.serial_id}.merge(@update_params)
|
2011-12-23 10:56:46 +00:00
|
|
|
@issue.reload.title.should == 'issue2'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples_for 'user without issue update rights' do
|
|
|
|
it 'should not be able to perform update action' do
|
2011-12-28 02:57:42 +00:00
|
|
|
put :update, {:id => @issue.serial_id}.merge(@update_params)
|
2012-04-05 18:11:02 +01:00
|
|
|
response.should redirect_to(controller.current_user ? forbidden_path : new_user_session_path)
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'should not update issue title' do
|
2011-12-28 02:57:42 +00:00
|
|
|
put :update, {:id => @issue.serial_id}.merge(@update_params)
|
2011-12-23 10:56:46 +00:00
|
|
|
@issue.reload.title.should_not == 'issue2'
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples_for 'user without issue destroy rights' do
|
|
|
|
it 'should not be able to perform destroy action' do
|
2012-04-23 21:55:42 +01:00
|
|
|
delete :destroy, :id => @issue.serial_id, :owner_name => @project.owner.uname, :project_name => @project.name
|
2012-04-05 18:11:02 +01:00
|
|
|
response.should redirect_to(controller.current_user ? forbidden_path : new_user_session_path)
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'should not reduce issues count' do
|
2012-04-23 21:55:42 +01:00
|
|
|
lambda{ delete :destroy, :id => @issue.serial_id, :owner_name => @project.owner.uname, :project_name => @project.name }.should_not change{ Issue.count }
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
shared_examples_for 'project with issues turned off' do
|
2012-09-06 18:45:13 +01:00
|
|
|
it 'should not be able to perform index action' do
|
2013-06-09 13:03:03 +01:00
|
|
|
get :index, :owner_name => @project_with_turned_off_issues.owner.uname, :project_name => @project_with_turned_off_issues.name
|
2012-09-06 18:45:13 +01:00
|
|
|
response.should redirect_to(forbidden_path)
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'should not be able to perform show action' do
|
2013-06-09 13:03:03 +01:00
|
|
|
get :show, :owner_name => @project_with_turned_off_issues.owner.uname, :project_name => @project_with_turned_off_issues.name, :id => @turned_of_issue.serial_id
|
2011-12-23 10:56:46 +00:00
|
|
|
response.should redirect_to(forbidden_path)
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-05-02 10:18:07 +01:00
|
|
|
describe Projects::IssuesController do
|
2012-08-15 14:52:32 +01:00
|
|
|
include_context "issues controller"
|
2011-12-23 10:56:46 +00:00
|
|
|
|
|
|
|
context 'for global admin user' do
|
|
|
|
before(:each) do
|
2012-09-06 18:45:13 +01:00
|
|
|
@user.role = "admin"
|
|
|
|
@user.save
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
2012-09-06 18:45:13 +01:00
|
|
|
it_should_behave_like 'issue user with project guest rights'
|
|
|
|
it_should_behave_like 'issue user with project reader rights'
|
|
|
|
it_should_behave_like 'issue user with project writer rights'
|
|
|
|
it_should_behave_like 'user with issue update rights'
|
|
|
|
it_should_behave_like 'project with issues turned off'
|
2011-12-23 10:56:46 +00:00
|
|
|
it_should_behave_like 'user without issue destroy rights'
|
|
|
|
end
|
|
|
|
|
|
|
|
context 'for project admin user' do
|
|
|
|
before(:each) do
|
2012-04-26 02:38:33 +01:00
|
|
|
@project.relations.create!(:actor_type => 'User', :actor_id => @user.id, :role => 'admin')
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
2012-09-06 18:45:13 +01:00
|
|
|
it_should_behave_like 'issue user with project guest rights'
|
2011-12-23 10:56:46 +00:00
|
|
|
it_should_behave_like 'issue user with project reader rights'
|
|
|
|
it_should_behave_like 'issue user with project writer rights'
|
|
|
|
it_should_behave_like 'user with issue update rights'
|
|
|
|
it_should_behave_like 'project with issues turned off'
|
2012-09-06 18:45:13 +01:00
|
|
|
it_should_behave_like 'user without issue destroy rights'
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'for project owner user' do
|
|
|
|
before(:each) do
|
2012-09-06 18:45:13 +01:00
|
|
|
@user = @project.owner
|
2011-12-23 10:56:46 +00:00
|
|
|
set_session_for(@user)
|
|
|
|
end
|
|
|
|
|
2012-09-06 18:45:13 +01:00
|
|
|
it_should_behave_like 'issue user with project guest rights'
|
2011-12-23 10:56:46 +00:00
|
|
|
it_should_behave_like 'issue user with project reader rights'
|
|
|
|
it_should_behave_like 'issue user with project writer rights'
|
|
|
|
it_should_behave_like 'user with issue update rights'
|
|
|
|
it_should_behave_like 'project with issues turned off'
|
2012-09-06 18:45:13 +01:00
|
|
|
it_should_behave_like 'user without issue destroy rights'
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'for project reader user' do
|
|
|
|
before(:each) do
|
2012-04-26 02:38:33 +01:00
|
|
|
@project.relations.create!(:actor_type => 'User', :actor_id => @user.id, :role => 'reader')
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
2012-09-06 18:45:13 +01:00
|
|
|
it_should_behave_like 'issue user with project guest rights'
|
2011-12-23 10:56:46 +00:00
|
|
|
it_should_behave_like 'issue user with project reader rights'
|
|
|
|
it_should_behave_like 'user without issue update rights'
|
|
|
|
it_should_behave_like 'project with issues turned off'
|
2012-09-06 18:45:13 +01:00
|
|
|
it_should_behave_like 'user without issue destroy rights'
|
2011-12-23 10:56:46 +00:00
|
|
|
|
2013-04-03 12:11:50 +01:00
|
|
|
context 'perform create action' do
|
|
|
|
before { post :create, @create_params }
|
|
|
|
|
|
|
|
it 'user should not be assigned to issue' do
|
|
|
|
@project.issues.last.assignee_id.should be_nil
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'label should not be attached to issue' do
|
|
|
|
@project.issues.last.labels.should have(:no).items
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2012-09-06 18:45:13 +01:00
|
|
|
# it 'should not be able to perform create action on project' do
|
|
|
|
# post :create, @create_params
|
|
|
|
# response.should redirect_to(forbidden_path)
|
|
|
|
# end
|
2011-12-23 10:56:46 +00:00
|
|
|
|
2012-09-06 18:45:13 +01:00
|
|
|
# it 'should not create issue object into db' do
|
|
|
|
# lambda{ post :create, @create_params }.should change{ Issue.count }.by(0)
|
|
|
|
# end
|
2013-07-22 16:19:25 +01:00
|
|
|
|
|
|
|
it 'should return 404' do
|
2013-07-22 20:27:55 +01:00
|
|
|
get :show, :owner_name => @project.owner.uname, :project_name => @project.name, :id => 999999
|
|
|
|
render_template(:file => "#{Rails.root}/public/404.html")
|
2013-07-22 16:19:25 +01:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'should redirect to pull request page' do
|
|
|
|
get :show, :owner_name => @project.owner.uname, :project_name => @project.name, :id => @pull.serial_id
|
|
|
|
response.should redirect_to(project_pull_request_path(@project, @pull))
|
|
|
|
end
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'for project writer user' do
|
|
|
|
before(:each) do
|
2012-04-26 02:38:33 +01:00
|
|
|
@project.relations.create!(:actor_type => 'User', :actor_id => @user.id, :role => 'writer')
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
2012-09-06 18:45:13 +01:00
|
|
|
it_should_behave_like 'issue user with project guest rights'
|
2011-12-23 10:56:46 +00:00
|
|
|
it_should_behave_like 'issue user with project reader rights'
|
|
|
|
it_should_behave_like 'issue user with project writer rights'
|
|
|
|
it_should_behave_like 'user without issue update rights'
|
|
|
|
it_should_behave_like 'project with issues turned off'
|
2012-09-06 18:45:13 +01:00
|
|
|
it_should_behave_like 'user without issue destroy rights'
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
context 'for issue assign user' do
|
|
|
|
before(:each) do
|
|
|
|
set_session_for(@issue_user)
|
|
|
|
end
|
2011-12-19 15:30:14 +00:00
|
|
|
|
2012-04-16 18:51:51 +01:00
|
|
|
it_should_behave_like 'user without issue update rights'
|
2011-12-23 10:56:46 +00:00
|
|
|
it_should_behave_like 'project with issues turned off'
|
2012-09-06 18:45:13 +01:00
|
|
|
it_should_behave_like 'user without issue destroy rights'
|
2011-12-23 10:56:46 +00:00
|
|
|
end
|
2012-04-05 18:11:02 +01:00
|
|
|
|
|
|
|
context 'for guest' do
|
2012-05-30 17:03:07 +01:00
|
|
|
|
2012-09-06 18:45:13 +01:00
|
|
|
before(:each) do
|
|
|
|
set_session_for(User.new)
|
|
|
|
end
|
2012-05-30 17:03:07 +01:00
|
|
|
|
2012-09-06 18:45:13 +01:00
|
|
|
if APP_CONFIG['anonymous_access']
|
|
|
|
|
|
|
|
it_should_behave_like 'issue user with project guest rights'
|
|
|
|
|
2012-05-30 17:03:07 +01:00
|
|
|
it 'should not be able to perform index action on hidden project' do
|
2012-09-06 11:53:03 +01:00
|
|
|
@project.update_attributes(:visibility => 'hidden')
|
2012-05-30 17:03:07 +01:00
|
|
|
get :index, :owner_name => @project.owner.uname, :project_name => @project.name
|
|
|
|
response.should redirect_to(forbidden_path)
|
|
|
|
end
|
2012-09-06 18:45:13 +01:00
|
|
|
|
2012-04-05 18:11:02 +01:00
|
|
|
else
|
|
|
|
it 'should not be able to perform index action' do
|
2012-04-23 21:55:42 +01:00
|
|
|
get :index, :owner_name => @project.owner.uname, :project_name => @project.name
|
2012-04-05 18:11:02 +01:00
|
|
|
response.should redirect_to(new_user_session_path)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'should not be able to perform show action' do
|
2012-04-23 21:55:42 +01:00
|
|
|
get :show, :owner_name => @project.owner.uname, :project_name => @project.name, :id => @issue.serial_id
|
2012-04-05 18:11:02 +01:00
|
|
|
response.should redirect_to(new_user_session_path)
|
|
|
|
end
|
2012-05-30 17:03:07 +01:00
|
|
|
|
|
|
|
it 'should not be able to perform index action on hidden project' do
|
2012-09-06 11:53:03 +01:00
|
|
|
@project.update_attributes(:visibility => 'hidden')
|
2012-05-30 17:03:07 +01:00
|
|
|
get :index, :owner_name => @project.owner.uname, :project_name => @project.name
|
|
|
|
response.should redirect_to(new_user_session_path)
|
|
|
|
end
|
2012-04-05 18:11:02 +01:00
|
|
|
end
|
|
|
|
|
|
|
|
it 'should not be able to perform create action' do
|
|
|
|
post :create, @create_params
|
|
|
|
response.should redirect_to(new_user_session_path)
|
|
|
|
end
|
|
|
|
|
|
|
|
it 'should not create issue object into db' do
|
|
|
|
lambda{ post :create, @create_params }.should_not change{ Issue.count }
|
|
|
|
end
|
|
|
|
|
|
|
|
it_should_behave_like 'user without issue update rights'
|
|
|
|
it_should_behave_like 'user without issue destroy rights'
|
|
|
|
end
|
2011-12-19 15:30:14 +00:00
|
|
|
end
|