rosa-build/spec/controllers/api/v1/pull_requests_controller.rb

# -*- encoding : utf-8 -*-
require 'spec_helper'

def create_pull to_ref, from_ref, owner, project = @project
  pull = project.pull_requests.new :issue_attributes => {:title => 'test', :body => 'testing'}
  pull.issue.user, pull.issue.project = owner, pull.to_project
  pull.to_ref, pull.from_ref, pull.from_project = to_ref, from_ref, project
  pull.save; pull.check
  pull
end

describe Api::V1::PullRequestsController do
  before(:all) do
    stub_symlink_methods
    stub_redis
    @project = FactoryGirl.create(:project_with_commit)
    @pull = create_pull 'master', 'non_conflicts', @project.owner

    @another_project = FactoryGirl.create(:project_with_commit)
    @another_pull = create_pull 'master', 'non_conflicts', @another_project.owner, @another_project

    @hidden_project = FactoryGirl.create(:project_with_commit)
    @hidden_project.update_column :visibility, 'hidden'
    @hidden_pull = create_pull 'master', 'non_conflicts', @hidden_project.owner, @hidden_project

    @own_hidden_project = FactoryGirl.create(:project_with_commit, :owner => @project.owner)
    @own_hidden_project.update_column :visibility, 'hidden'
    @own_hidden_pull = create_pull 'master', 'non_conflicts', @own_hidden_project.owner, @own_hidden_project
    @own_hidden_pull.issue.update_column :assignee_id, @project.owner.id

    @membered_project = FactoryGirl.create(:project_with_commit)
    @membered_pull = create_pull 'master', 'non_conflicts', @membered_project.owner, @membered_project
    @membered_project.relations.create(:role => 'reader', :actor => @pull.user)

    @create_params = {:pull_request => {:title => 'title', :body => 'body',
                                        :from_ref => 'conflicts', :to_ref => 'master'},
                      :project_id => @project.id, :format => :json}

    @update_params = {:pull_request => {:title => 'new title'},
                      :project_id => @project.id, :id => @pull.serial_id, :format => :json}

    @issue = FactoryGirl.create(:issue, :project => @project)
  end

  context 'read and accessible abilities' do
    context 'for user' do
      before(:each) do
        http_login(@project.owner)
      end

      it 'can show pull request in own project' do
        get :show, :project_id => @project.id, :id => @pull.serial_id, :format => :json
        response.should be_success
      end

      it 'should render right template for show action' do
        get :show, :project_id => @project.id, :id => @pull.serial_id, :format => :json
        response.should render_template('api/v1/pull_requests/show')
      end

      it 'can show pull request in open project' do
        get :show, :project_id => @another_project.id, :id => @another_pull.serial_id, :format => :json
        response.should be_success
      end

      it 'can show pull request in own hidden project' do
        get :show, :project_id => @own_hidden_project.id, :id => @own_hidden_pull.serial_id, :format => :json
        response.should be_success
      end

      it 'cant show pull request in hidden project' do
        get :show, :project_id => @hidden_project.id, :id => @hidden_pull.serial_id, :format => :json
        response.status.should == 403
      end

      it 'should return three pull requests' do
        get :all_index, :filter => 'all', :format => :json
        assigns[:pulls].should include(@pull)
        assigns[:pulls].should include(@own_hidden_pull)
        assigns[:pulls].should include(@membered_pull)
      end

      it 'should render right template for all index action' do
        get :all_index, :format => :json
        response.should render_template('api/v1/pull_requests/index')
      end

      it 'should return only assigned pull request' do
        get :user_index, :format => :json
        assigns[:pulls].should include(@own_hidden_pull)
        assigns[:pulls].should have(1).item
      end

      it 'should render right template for user index action' do
        get :user_index, :format => :json
        response.should render_template('api/v1/pull_requests/index')
      end

      %w(commits files).each do |action|
        it "can show pull request #{action} in own project" do
          get action, :project_id => @project.id, :id => @pull.serial_id, :format => :json
          response.should be_success
        end

        it "should render right template for commits action" do
          get action, :project_id => @project.id, :id => @pull.serial_id, :format => :json
          response.should render_template("api/v1/pull_requests/#{action}")
        end

        it "can't show pull request #{action} in hidden project" do
          get action, :project_id => @hidden_project.id, :id => @hidden_pull.serial_id, :format => :json
          response.should_not be_success
        end
      end

      it 'should return 404' do
        get :show, :project_id => @project.id, :id => (@pull.serial_id+10), :format => :json
        response.status.should == 404
      end

      it 'should redirect to issue page' do
        get :show, :project_id => @project.id, :id => @issue.serial_id, :format => :json
        response.should redirect_to(api_v1_project_issue_path(@project.id, @issue.serial_id))
      end
    end

    context 'for anonymous user' do
      it 'can show pull request in open project', :anonymous_access => true do
        get :show, :project_id => @project.id, :id => @pull.serial_id, :format => :json
        response.should be_success
      end

      it 'cant show pull request in hidden project', :anonymous_access => true do
        @project.update_column :visibility, 'hidden'
        get :show, :project_id => @project.id, :id => @pull.serial_id, :format => :json
        response.status.should == 403
      end

      it 'should not return any pull requests' do
        get :all_index, :filter => 'all', :format => :json
        response.status.should == 401
      end

      %w(commits files).each do |action|
        it "can show pull request #{action} in project" do
          get action, :project_id => @project.id, :id => @pull.serial_id, :format => :json
          response.should be_success
        end

        it "should render right template for commits action" do
          get action, :project_id => @project.id, :id => @pull.serial_id, :format => :json
          response.should render_template("api/v1/pull_requests/#{action}")
        end

        it "can't show pull request #{action} in hidden project" do
          get action, :project_id => @hidden_project.id, :id => @hidden_pull.serial_id, :format => :json
          response.should_not be_success
        end
      end
    end
  end

  context 'create accessibility' do
    context 'for user' do
      before(:each) do
        http_login(@pull.user)
      end

      it 'can create pull request in own project' do
        lambda { post :create, @create_params }.should change{ PullRequest.count }.by(1)
      end

      it 'can create pull request in own hidden project' do
        lambda { post :create, @create_params.merge(:project_id => @own_hidden_project.id) }.should
          change{ PullRequest.count }.by(1)
      end

      it 'can create pull request in open project' do
        lambda { post :create, @create_params.merge(:project_id => @another_project.id) }.should
          change{ PullRequest.count }.by(1)
      end

      it 'cant create pull request in hidden project' do
        lambda { post :create, @create_params.merge(:project_id => @hidden_project.id) }.should
          change{ PullRequest.count }.by(0)
      end
    end

    context 'for anonymous user' do
      it 'cant create pull request in project', :anonymous_access => true do
        lambda { post :create, @create_params }.should change{ PullRequest.count }.by(0)
      end

      it 'cant create pull request in hidden project', :anonymous_access => true do
        lambda { post :create, @create_params.merge(:project_id => @hidden_project.id) }.should
          change{ PullRequest.count }.by(0)
      end
    end
  end

  context 'update accessibility' do
    context 'for user' do
      before(:each) do
        http_login(@project.owner)
      end

      it 'can update pull request in own project' do
        put :update, @update_params
        @pull.reload.title.should == 'new title'
      end

      it 'can update pull request in own hidden project' do
        put :update, @update_params.merge(:project_id => @own_hidden_project.id, :id => @own_hidden_pull.serial_id)
        @own_hidden_pull.reload.title.should == 'new title'
      end

      it 'cant update pull request in open project' do
        put :update, @update_params.merge(:project_id => @another_project.id, :id => @another_pull.serial_id)
        @another_pull.reload.title.should_not == 'new title'
      end

      it 'cant update pull request in hidden project' do
        put :update, @update_params.merge(:project_id => @hidden_project.id, :id => @hidden_pull.serial_id)
        @hidden_pull.reload.title.should_not == 'title'
      end

      it 'can merge pull request in own project' do
        put :merge, :project_id => @project.id, :id => @pull.serial_id, :format => :json
        @pull.reload.status.should == 'merged'
        response.should be_success
      end

      it 'can merge pull request in own hidden project' do
        put :merge, :project_id => @own_hidden_project.id, :id => @own_hidden_pull.serial_id, :format => :json
        @own_hidden_pull.reload.status.should == 'merged'
        response.should be_success
      end

      it 'cant merge pull request in open project' do
        put :merge, :project_id => @another_project.id, :id => @another_pull.serial_id, :format => :json
        @another_pull.reload.status.should == 'ready'
        response.status.should == 403
      end

      it 'cant merge pull request in hidden project' do
        put :merge, :project_id => @hidden_project.id, :id => @hidden_pull.serial_id, :format => :json
        @hidden_pull.reload.status.should == 'ready'
        response.status.should == 403
      end
    end

    context 'for anonymous user' do
      it 'cant update pull request in project', :anonymous_access => true do
        put :update, @update_params
        response.status.should == 401
      end

      it 'cant update pull request in hidden project', :anonymous_access => true do
        put :update, @update_params.merge(:project_id => @hidden_project.id, :id => @hidden_pull.serial_id)
        response.status.should == 401
      end

      it 'cant merge pull request in open project' do
        put :merge, :project_id => @another_project.id, :id => @another_pull.serial_id, :format => :json
        @another_pull.reload.status.should == 'ready'
        response.status.should == 401
      end

      it 'cant merge pull request in hidden project' do
        put :merge, :project_id => @hidden_project.id, :id => @hidden_pull.serial_id, :format => :json
        @hidden_pull.reload.status.should == 'ready'
        response.status.should == 401
      end
    end
  end

  context 'send email messages' do
    before(:each) do
      @project_reader = FactoryGirl.create :user
      @project.relations.create!(:actor_type => 'User', :actor_id => @project_reader.id, :role => 'reader')
      @project_admin = FactoryGirl.create :user
      @project.relations.create!(:actor_type => 'User', :actor_id => @project_admin.id, :role => 'admin')
      @project_writer = FactoryGirl.create :user
      @project.relations.create!(:actor_type => 'User', :actor_id => @project_writer.id, :role => 'writer')

      http_login(@project_writer)
      ActionMailer::Base.deliveries = []
    end

    it 'should send two email messages to project admins' do
      post :create, @create_params
      @project.pull_requests.last.issue.send(:new_issue_notifications)
      @project.pull_requests.last.issue.send(:send_assign_notifications)
      ActionMailer::Base.deliveries.count.should == 2
    end

    it 'should send two email messages to admins and one to assignee' do
      post :create, @create_params.deep_merge(:pull_request => {:assignee_id => @project_reader.id})
      @project.pull_requests.last.issue.send(:new_issue_notifications)
      @project.pull_requests.last.issue.send(:send_assign_notifications)
      ActionMailer::Base.deliveries.count.should == 3
    end

    it 'should send email message to new assignee' do
      put :update, @update_params.deep_merge(:pull_request => {:assignee_id => @project_reader.id})
      @project.pull_requests.last.issue.send(:send_assign_notifications)
      ActionMailer::Base.deliveries.count.should == 1
    end

    it 'should not duplicate email message' do
      post :create, @create_params.deep_merge(:pull_request => {:assignee_id => @project_admin.id})
      @project.pull_requests.last.issue.send(:new_issue_notifications)
      @project.pull_requests.last.issue.send(:send_assign_notifications)
      ActionMailer::Base.deliveries.count.should == 2 # send only to admins
      ActionMailer::Base.deliveries.first.to != ActionMailer::Base.deliveries.last.to
    end
  end

  after(:all) do
    User.destroy_all
    Platform.destroy_all
  end
end