rosa-build/spec/controllers/projects/build_lists_controller_spec.rb

523 lines
19 KiB
Ruby
Raw Normal View History

require 'spec_helper'
2015-02-19 01:12:08 +00:00
describe Projects::BuildListsController, type: :controller do
shared_examples_for 'show build list' do
it 'should be able to perform show action' do
get :show, @show_params
expect(response).to be_success
end
it 'should be able to perform index action in project scope' do
get :index, name_with_owner: @project.name_with_owner
expect(response).to be_success
end
end
shared_examples_for 'not show build list' do
it 'should not be able to perform show action' do
get :show, @show_params
expect(response).to redirect_to(forbidden_url)
end
it 'should not be able to perform index action in project scope' do
get :index, name_with_owner: @project.name_with_owner
expect(response).to redirect_to(forbidden_url)
end
end
shared_examples_for 'create build list' do
before {
@project.update_attribute(:repositories, @platform.repositories)
}
it 'should be able to perform new action' do
get :new, name_with_owner: @project.name_with_owner
expect(response).to render_template(:new)
end
it 'should be able to perform create action' do
post :create, { name_with_owner: @project.name_with_owner }.merge(@create_params)
expect(response).to redirect_to project_build_lists_path(@project)
end
it 'should save correct commit_hash for branch based build' do
post :create, { name_with_owner: @project.name_with_owner }.merge(@create_params).deep_merge(build_list: { project_version: "master" })
expect(@project.build_lists.last.commit_hash).to eq @project.repo.commits('master').first.id
end
it 'should save correct commit_hash for tag based build' do
system("cd #{@project.repo.path} && git tag 4.7.5.3") # TODO REDO through grit
post :create, { name_with_owner: @project.name_with_owner }.merge(@create_params).deep_merge(build_list: { project_version: "4.7.5.3" })
expect(@project.build_lists.last.commit_hash).to eq @project.repo.commits('4.7.5.3').first.id
end
2012-10-11 11:55:06 +01:00
it 'should not be able to create with wrong project version' do
expect do
post :create, { name_with_owner: @project.name_with_owner }.merge(@create_params).deep_merge(build_list: { project_version: "wrong", commit_hash: nil })
end.to_not change{ @project.build_lists.count }
2012-10-11 11:55:06 +01:00
end
it 'should not be able to create with wrong git hash' do
expect do
post :create, { name_with_owner: @project.name_with_owner }.merge(@create_params).deep_merge(build_list: { commit_hash: 'wrong' })
end.to_not change{ @project.build_lists.count }
2012-10-11 11:55:06 +01:00
end
end
shared_examples_for 'not create build list' do |skip_new = false|
before {
@project.update_attribute(:repositories, @platform.repositories)
}
it 'should not be able to perform new action' do
get :new, name_with_owner: @project.name_with_owner
expect(response).to redirect_to(forbidden_url)
end unless skip_new
it 'should not be able to perform create action' do
post :create, { name_with_owner: @project.name_with_owner }.merge(@create_params)
expect(response).to redirect_to(forbidden_url)
end
end
2014-05-28 22:53:50 +01:00
before { stub_symlink_methods }
context 'crud' do
2014-05-22 19:08:43 +01:00
before do
@platform = FactoryGirl.create(:platform_with_repos)
@create_params = {
2014-01-21 04:51:49 +00:00
build_list: {
project_version: 'master',
save_to_repository_id: @platform.repositories.first.id,
update_type: 'security',
include_repos: [@platform.repositories.first.id]
},
2014-01-21 04:51:49 +00:00
arches: [FactoryGirl.create(:arch).id],
build_for_platforms: [@platform.id]
}
2015-02-19 01:28:02 +00:00
allow_any_instance_of(Project).to receive(:versions).and_return(%w(v1.0 v2.0))
end
context 'for guest' do
2014-01-21 04:51:49 +00:00
it 'should be able to perform index action', anonymous_access: true do
get :index
expect(response).to be_success
end
2014-01-21 04:51:49 +00:00
it 'should not be able to perform index action', anonymous_access: false do
get :index
expect(response).to redirect_to(new_user_session_path)
end
end
context 'for user' do
2015-06-19 22:24:57 +01:00
let(:user) { FactoryGirl.create(:user) }
2014-05-22 19:08:43 +01:00
before do
2015-02-19 01:28:02 +00:00
allow_any_instance_of(BuildList).to receive(:current_duration).and_return(100)
2013-07-01 13:20:38 +01:00
@build_list = FactoryGirl.create(:build_list)
2011-12-14 21:04:39 +00:00
@project = @build_list.project
@owner_user = @project.owner
@show_params = { name_with_owner: @project.name_with_owner, id: @build_list.id }
@build_list.save_to_repository.update_column(:publish_without_qa, false)
@request.env['HTTP_REFERER'] = build_list_path(@build_list)
end
2014-05-22 19:08:43 +01:00
context 'do rerun_tests' do
def do_rerun_tests
put :rerun_tests, id: @build_list
end
2014-05-28 22:53:50 +01:00
before do
allow_any_instance_of(BuildList).to receive(:can_rerun_tests?).and_return(true)
end
2014-05-22 19:08:43 +01:00
context 'if user is project owner' do
before { set_session_for(@owner_user) }
it 'reruns tests' do
expect_any_instance_of(BuildList).to receive(:rerun_tests).and_return(true)
do_rerun_tests
expect(response).to redirect_to(build_list_path(@build_list))
expect(flash[:notice]).to match I18n.t('layout.build_lists.rerun_tests_success')
end
it 'returns an error if the can not rerun_tests' do
allow_any_instance_of(BuildList).to receive(:rerun_tests).and_return(false)
do_rerun_tests
expect(response).to redirect_to(build_list_path(@build_list))
expect(flash[:error]).to match I18n.t('layout.build_lists.rerun_tests_fail')
end
end
it 'returns an error if user is not project owner' do
2015-06-19 22:24:57 +01:00
set_session_for(user)
2014-05-22 19:08:43 +01:00
expect_any_instance_of(BuildList).to_not receive(:rerun_tests)
do_rerun_tests
expect(response).to redirect_to(forbidden_url)
end
it 'returns an error if user is project reader' do
@another_user = FactoryGirl.create(:user)
Collaborator.create(actor_type: 'User', actor_id: @another_user.id, role: 'reader', project: @build_list.project)
2014-05-22 19:08:43 +01:00
set_session_for(@another_user)
expect_any_instance_of(BuildList).to_not receive(:rerun_tests)
do_rerun_tests
expect(response).to redirect_to(forbidden_url)
end
it 'reruns tests if user is project writer' do
@writer_user = FactoryGirl.create(:user)
create_relation(@build_list.project, @writer_user, 'writer')
set_session_for(@writer_user)
expect_any_instance_of(BuildList).to receive(:rerun_tests).and_return(true)
do_rerun_tests
expect(response).to redirect_to(build_list_path(@build_list))
expect(flash[:notice]).to match I18n.t('layout.build_lists.rerun_tests_success')
end
end
context "do reject_publish" do
2014-05-22 19:08:43 +01:00
before {@build_list.save_to_repository.update_column(:publish_without_qa, true)}
def do_reject_publish
2014-01-21 04:51:49 +00:00
put :reject_publish, id: @build_list
end
context 'if user is project owner' do
2014-05-22 19:08:43 +01:00
before do
set_session_for(@owner_user)
@build_list.update_column(:status, BuildList::SUCCESS)
@build_list.save_to_platform.update_column(:released, true)
do_reject_publish
end
context "if it has :success status" do
it 'should return 302 response code' do
expect(response.status).to eq 302
end
it "should reject publish build list" do
expect(@build_list.reload.status).to eq BuildList::REJECTED_PUBLISH
end
end
context "if it has another status" do
2014-05-22 19:08:43 +01:00
before do
@build_list.update_column(:status, BuildList::BUILD_ERROR)
do_reject_publish
end
it "should not change status of build list" do
expect(@build_list.reload.status).to eq BuildList::BUILD_ERROR
end
end
end
context 'if user is not project owner' do
2014-05-22 19:08:43 +01:00
before do
@build_list.update_column(:status, BuildList::SUCCESS)
@build_list.save_to_platform.update_column(:released, true)
2015-06-19 22:24:57 +01:00
set_session_for(user)
do_reject_publish
end
it "should redirect to forbidden page" do
expect(response).to redirect_to(forbidden_url)
end
it "should not change status of build list" do
do_reject_publish
expect(@build_list.reload.status).to eq BuildList::SUCCESS
end
end
context 'if user is project reader' do
2014-05-22 19:08:43 +01:00
before do
@another_user = FactoryGirl.create(:user)
@build_list.update_column(:status, BuildList::SUCCESS)
@build_list.save_to_repository.update_column(:publish_without_qa, true)
Collaborator.create(actor_type: 'User', actor_id: @another_user.id, role: 'reader', project: @build_list.project)
set_session_for(@another_user)
do_reject_publish
end
it "should redirect to forbidden page" do
expect(response).to redirect_to(forbidden_url)
end
it "should not change status of build list" do
do_reject_publish
expect(@build_list.reload.status).to eq BuildList::SUCCESS
end
end
context 'if user is project writer' do
2014-05-22 19:08:43 +01:00
before do
@writer_user = FactoryGirl.create(:user)
@build_list.update_column(:status, BuildList::SUCCESS)
@build_list.save_to_repository.update_column(:publish_without_qa, true)
create_relation(@build_list.project, @writer_user, 'writer')
set_session_for(@writer_user)
do_reject_publish
end
it 'should return 302 response code' do
expect(response.status).to eq 302
end
it "should reject publish build list" do
expect(@build_list.reload.status).to eq BuildList::REJECTED_PUBLISH
end
end
2011-12-14 21:04:39 +00:00
end
context 'for all build lists' do
2014-05-22 19:08:43 +01:00
before do
2013-07-01 13:20:38 +01:00
@build_list1 = FactoryGirl.create(:build_list)
2012-10-11 11:55:06 +01:00
2013-07-01 13:20:38 +01:00
@build_list2 = FactoryGirl.create(:build_list)
@build_list2.project.update_column(:visibility, 'hidden')
2012-10-11 11:55:06 +01:00
2015-06-19 22:24:57 +01:00
project = FactoryGirl.create(:project_with_commit, visibility: 'hidden', owner: user)
2014-01-21 04:51:49 +00:00
@build_list3 = FactoryGirl.create(:build_list_with_attaching_project, project: project)
2012-10-11 11:55:06 +01:00
2013-07-01 13:20:38 +01:00
@build_list4 = FactoryGirl.create(:build_list)
@build_list4.project.update_column(:visibility, 'hidden')
2015-06-19 22:24:57 +01:00
create_relation(@build_list4.project, user, 'reader')
set_session_for(user)
end
it 'should be able to perform index action' do
get :index
expect(response).to be_success
end
it 'should show only accessible build_lists' do
get :index, filter: {ownership: 'everything'}, format: :json
expect(assigns(:build_lists)).to include(@build_list1)
expect(assigns(:build_lists)).to_not include(@build_list2)
expect(assigns(:build_lists)).to include(@build_list3)
expect(assigns(:build_lists)).to include(@build_list4)
end
end
2011-12-14 21:04:39 +00:00
2011-12-14 21:30:15 +00:00
context 'for open project' do
2015-06-19 22:24:57 +01:00
context 'for user' do
before { set_session_for(user) }
it_should_behave_like 'show build list'
it_should_behave_like 'not create build list'
end
2011-12-14 21:04:39 +00:00
2011-12-14 21:30:15 +00:00
context 'if user is project owner' do
2014-05-22 19:08:43 +01:00
before {set_session_for(@owner_user)}
2011-12-14 21:30:15 +00:00
it_should_behave_like 'show build list'
it_should_behave_like 'create build list'
context 'no ability to read build_for_platform' do
before do
repository = FactoryGirl.create(:repository)
repository.platform.change_visibility
2014-01-21 04:51:49 +00:00
Platform.where(id: @platform.id).update_all(platform_type: 'personal')
@create_params[:build_list].merge!({include_repos: [repository.id]})
@create_params[:build_for_platforms] = [repository.platform_id]
end
it_should_behave_like 'not create build list', true
end
2011-12-14 21:04:39 +00:00
end
context 'if user is project read member' do
2015-06-19 22:24:57 +01:00
before do
@member_user = FactoryGirl.create(:user)
create_relation(@project, @member_user, 'reader')
set_session_for(@member_user)
end
2011-12-14 21:30:15 +00:00
it_should_behave_like 'show build list'
it_should_behave_like 'not create build list'
2011-12-14 21:04:39 +00:00
end
end
2011-12-14 21:30:15 +00:00
context 'for hidden project' do
2014-05-22 19:08:43 +01:00
before do
2015-06-19 22:24:57 +01:00
@project.update_column(:visibility, 'hidden')
2011-12-14 21:30:15 +00:00
end
2015-06-19 22:24:57 +01:00
context 'for user' do
before { set_session_for(user) }
it_should_behave_like 'not show build list'
it_should_behave_like 'not create build list'
end
2011-12-14 21:30:15 +00:00
context 'if user is project owner' do
2014-05-22 19:08:43 +01:00
before {set_session_for(@owner_user)}
2011-12-14 21:30:15 +00:00
it_should_behave_like 'show build list'
it_should_behave_like 'create build list'
2011-12-14 21:04:39 +00:00
end
context 'if user is project read member' do
2015-06-19 22:24:57 +01:00
before do
@member_user = FactoryGirl.create(:user)
create_relation(@project, @member_user, 'reader')
set_session_for(@member_user)
end
2011-12-14 21:30:15 +00:00
it_should_behave_like 'show build list'
it_should_behave_like 'not create build list'
2011-12-14 21:04:39 +00:00
end
end
end
2011-12-20 12:59:09 +00:00
context 'for group' do
2015-06-19 22:24:57 +01:00
let(:user) { FactoryGirl.create(:user) }
2014-05-22 19:08:43 +01:00
before do
@build_list = FactoryGirl.create(:build_list_by_group_project)
@project = @build_list.project
@owner_group = @build_list.project.owner
@owner_user = @owner_group.owner
@show_params = { name_with_owner: @project.name_with_owner, id: @build_list.id }
2011-12-20 12:59:09 +00:00
end
2012-10-11 11:55:06 +01:00
2011-12-20 12:59:09 +00:00
context 'for all build lists' do
2014-05-22 19:08:43 +01:00
before do
2013-07-01 13:20:38 +01:00
@build_list1 = FactoryGirl.create(:build_list)
2012-10-11 11:55:06 +01:00
2013-07-01 13:20:38 +01:00
@build_list2 = FactoryGirl.create(:build_list)
@build_list2.project.update_column(:visibility, 'hidden')
2012-10-11 11:55:06 +01:00
2015-06-19 22:24:57 +01:00
project = FactoryGirl.create(:project_with_commit, visibility: 'hidden', owner: user)
2014-01-21 04:51:49 +00:00
@build_list3 = FactoryGirl.create(:build_list_with_attaching_project, project: project)
2012-10-11 11:55:06 +01:00
2013-07-01 13:20:38 +01:00
@build_list4 = FactoryGirl.create(:build_list)
@build_list4.project.update_column(:visibility, 'hidden')
2015-06-19 22:24:57 +01:00
create_relation(@build_list4.project, user, 'reader')
set_session_for(user)
2011-12-20 12:59:09 +00:00
end
it 'should be able to perform index action' do
get :index
expect(response).to be_success
2011-12-20 12:59:09 +00:00
end
it 'should show only accessible build_lists' do
get :index, filter: {ownership: 'everything'}, format: :json
expect(assigns(:build_lists)).to include(@build_list1)
expect(assigns(:build_lists)).to_not include(@build_list2)
expect(assigns(:build_lists)).to include(@build_list3)
expect(assigns(:build_lists)).to include(@build_list4)
2011-12-20 12:59:09 +00:00
end
end
context 'for open project' do
2015-06-19 22:24:57 +01:00
context 'for user' do
before { set_session_for(user) }
it_should_behave_like 'show build list'
it_should_behave_like 'not create build list'
end
2011-12-20 12:59:09 +00:00
context 'if user is group owner' do
2014-05-22 19:08:43 +01:00
before {set_session_for(@owner_user)}
2011-12-20 12:59:09 +00:00
it_should_behave_like 'show build list'
it_should_behave_like 'create build list'
2011-12-20 12:59:09 +00:00
end
context 'if user is group read member' do
2015-06-19 22:24:57 +01:00
before do
@member_group = FactoryGirl.create(:group)
@member_user = FactoryGirl.create(:user)
create_actor_relation(@member_group, @member_user, 'reader')
create_relation(@project, @member_group, 'reader')
set_session_for(@member_user)
end
2011-12-20 12:59:09 +00:00
it_should_behave_like 'show build list'
it_should_behave_like 'not create build list'
2011-12-20 12:59:09 +00:00
end
end
context 'for hidden project' do
2014-05-22 19:08:43 +01:00
before do
2015-06-19 22:24:57 +01:00
@project.update_column(:visibility, 'hidden')
2011-12-20 12:59:09 +00:00
end
2015-06-19 22:24:57 +01:00
context 'for user' do
before { set_session_for(user) }
it_should_behave_like 'not show build list'
it_should_behave_like 'not create build list'
end
2011-12-20 12:59:09 +00:00
context 'if user is group owner' do
2014-05-22 19:08:43 +01:00
before {set_session_for(@owner_user)}
2011-12-20 12:59:09 +00:00
it_should_behave_like 'show build list'
it_should_behave_like 'create build list'
2011-12-20 12:59:09 +00:00
end
context 'if user is group read member' do
2015-06-19 22:24:57 +01:00
before do
@member_group = FactoryGirl.create(:group)
@member_user = FactoryGirl.create(:user)
create_actor_relation(@member_group, @member_user, 'reader')
create_relation(@project, @member_group, 'reader')
set_session_for(@member_user)
end
2011-12-20 12:59:09 +00:00
it_should_behave_like 'show build list'
it_should_behave_like 'not create build list'
2011-12-20 12:59:09 +00:00
end
end
end
2013-01-21 17:16:06 +00:00
end
2011-12-20 12:59:09 +00:00
context 'filter' do
2012-10-11 11:55:06 +01:00
2014-05-22 19:08:43 +01:00
before do
set_session_for FactoryGirl.create(:admin)
2011-12-20 12:59:09 +00:00
2013-07-01 13:20:38 +01:00
@build_list1 = FactoryGirl.create(:build_list)
@build_list2 = FactoryGirl.create(:build_list)
@build_list3 = FactoryGirl.create(:build_list)
2014-01-21 04:51:49 +00:00
@build_list4 = FactoryGirl.create(:build_list, updated_at: (Time.now - 1.day),
project: @build_list3.project, save_to_platform: @build_list3.save_to_platform,
arch: @build_list3.arch)
2011-12-13 16:37:57 +00:00
end
2013-07-01 13:20:38 +01:00
it 'should filter by id' do
2014-01-21 04:51:49 +00:00
get :index, filter: {id: @build_list1.id, project_name: 'fdsfdf', any_other_field: 'do not matter'}, format: :json
expect(assigns[:build_lists]).to include(@build_list1)
expect(assigns[:build_lists]).to_not include(@build_list2)
expect(assigns[:build_lists]).to_not include(@build_list3)
end
it 'should filter by project_name' do
2014-01-21 04:51:49 +00:00
# Project.where(id: build_list2.project.id).update_all(name: 'project_name')
get :index, filter: {project_name: @build_list2.project.name, ownership: 'everything'}, format: :json
expect(assigns[:build_lists]).to_not include(@build_list1)
expect(assigns[:build_lists]).to include(@build_list2)
expect(assigns[:build_lists]).to_not include(@build_list3)
end
2011-12-13 13:35:16 +00:00
it 'should filter by project_name and update_date' do
2014-01-21 04:51:49 +00:00
get :index, filter: {project_name: @build_list3.project.name, ownership: 'everything',
"updated_at_start" => @build_list3.updated_at.strftime('%d/%m/%Y')}, format: :json
expect(assigns[:build_lists]).to_not include(@build_list1)
expect(assigns[:build_lists]).to_not include(@build_list2)
expect(assigns[:build_lists]).to include(@build_list3)
expect(assigns[:build_lists]).to_not include(@build_list4)
2011-12-13 13:35:16 +00:00
end
end
after(:all) {clean_projects_dir}
end